feat!: allow overrides for fractional seed#737
Merged
Kavindu-Dodan merged 9 commits intoopen-feature:mainfrom Apr 11, 2024
Merged
feat!: allow overrides for fractional seed#737Kavindu-Dodan merged 9 commits intoopen-feature:mainfrom
Kavindu-Dodan merged 9 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: Cole Bailey <cole.bailey@deliveryhero.com>
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
Collaborator
|
@colebaileygit thanks for the PR. Yes, this is a special situation (a breaking change in the evaluation core) where we have to wait for flagd release so that e2e tests can use the latest flagd instance. I think we could release flagd within this week so this too can get merged soon. |
Kavindu-Dodan
force-pushed
the
feat/fractional-custom-seed
branch
from
6f6ecad to
b8ff8eb
Compare
Signed-off-by: Cole Bailey <cole.bailey@deliveryhero.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…9.1.0 (open-feature#736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…plugin to v3.3.1 (open-feature#738) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
…ature#740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/fractional-custom-seed
branch
from
28e3784 to
5050ee0
Compare
Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Kavindu-Dodan
approved these changes
Apr 11, 2024
Collaborator
|
@colebaileygit build is green with updated test setu[ 🙌 |
Collaborator
|
Related - Go Provider update - open-feature/go-sdk-contrib#495 |
beeme1mr
approved these changes
Apr 11, 2024
toddbaert
reviewed
Apr 11, 2024
toddbaert
approved these changes
Apr 11, 2024
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Amazing work @colebaileygit . Thanks so much.
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…t to cc61a07 (open-feature#737) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
FLAGD_HOSTvarRelated Issues
open-feature/flagd#1264
Notes
Unit tests and in-process e2e test suites pass.
RPC e2e test suite still failing since the testbed is still using golang version without the fix.
Follow-up Tasks
How to test